-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to use blackbox testing, move tests to separate module #35
base: main
Are you sure you want to change the base?
Conversation
d2ad08c
to
d2f5e41
Compare
d2f5e41
to
6523db6
Compare
6523db6
to
a5b1cb2
Compare
Okay, moved this out of draft for consideration. |
newSize := Winsize{Width: 200, Height: 200, x: winSize.x, y: winSize.y} | ||
newSize := Winsize{Width: 200, Height: 200} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think this was the bit I was still looking at. It's somewhat unclear why x
and y
aren't exported; effectively WinSize
in this module is identical to golang.org/x/sys/unix.Winsize`;
Type in this module:
// Winsize represents the size of the terminal window.
type Winsize struct {
Height uint16
Width uint16
x uint16
y uint16
}
And in golang.org/x/sys:
type Winsize struct {
Row uint16
Col uint16
Xpixel uint16
Ypixel uint16
}
In this module, we're converting the types between, so perhaps instead we should make it an alias (and deprecate the local type). Let me look at that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! I recall now; for Windows, it's a different type, so we can make it an alias (but only on !windows)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm.. nevermind; field names are different 🤦
a5b1cb2
to
a6a5c39
Compare
This allows us to remove the test-dependencies from the module itself Signed-off-by: Sebastiaan van Stijn <[email protected]>
a6a5c39
to
3e71216
Compare
This allows us to remove the test-dependencies from the module itself.