-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a windows_dev.md document for buildkit developers on Windows #5291
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just those last comments and LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits into one.
abff257
to
4f81f3c
Compare
/cc. @crazy-max |
I am following these steps to setup on my local machine, and there is a place where you said, "Remove any other buildkit binary available in $env:PATH". When I
my question is which ones should I remove? |
Hi @castrombithisamm . The files you should remove or rename is both buildkitctl.exe and buildkitd.exe |
4f81f3c
to
8bd5090
Compare
Hi @danielGithinji thank you for getting back, so that means I should delete them from the
|
@castrombithisamm, when you install buildkit for the 1st time (using these instructions) its found in
When running buildkit and in order for there to be no conflicts between the buildkit binary in your PATH i.e |
I hear you @danielGithinji and thanks for clarifying this. I forgot to mention that my PATH
Maybe it would have been easier to understand if we listed all locations where the buildkit binary is available using
I don't know if I am correct, but this means my buildkit binary is installed in To conclude maybe we can say that we need to make sure that |
8bd5090
to
3e161da
Compare
@castrombithisamm - I have updated the document based on your sentiments so that it becomes clear how someone would need to proceed in this specific scenario. |
@danielGithinji many thanks for incorporating my sentiments into the document |
@crazy-max -- can take a look at this? |
**Prerequisites**: | ||
- You've setup Go and the buildkit repo and you can build from source. | ||
- Optional: You have installed the [Delve debugger](https://github.com/go-delve/delve) | ||
|
||
### Main Steps | ||
- Install `registry.exe` by running the following command: | ||
|
||
```go install -v github.com/distribution/distribution/v3/cmd/registry@latest``` | ||
- Install buildkit with the following command: | ||
``` | ||
cd to repo directory | ||
go install -v .\cmd\... | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary, you can just run:
docker buildx bake binaries-for-test --set *.platform=windows/amd64
To output dev binaries:
$ tree -nh ./bin/build
[4.0K] ./bin/build
├── [ 29M] buildctl.exe
├── [ 56M] buildkitd.exe
├── [ 17M] containerd-shim-runhcs-v1.exe
├── [ 37M] containerd.exe
├── [2.2M] gocovmerge.exe
├── [7.5M] gotestsum.exe
├── [ 573] gotestsumandcover
└── [ 23M] registry.exe
0 directories, 8 files
Will open a PR to also include delve
So just cloning repo, installing go and command above should be enough to get started.
docs/windows.md
Outdated
@@ -243,7 +243,7 @@ $networkName = 'nat' | |||
# Get-HnsNetwork is available once you have enabled the 'Hyper-V Host Compute Service' feature | |||
# which must have been done at the Quick setup above | |||
# Enable-WindowsOptionalFeature -Online -FeatureName containers -All | |||
# Enable-WindowsOptionalFeature -Online -FeatureName Microsoft-Hyper-V-All -All | |||
# Enable-WindowsOptionalFeature -Online -FeatureName Microsoft-Hyper-V -All |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not seem related to this PR, can you open a new one for this fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed it. I'll open a new one to fix it.
### Running the whole test-suite | ||
Running the whole test suite can take a long time, and it's not advisable to do it on your local machine. However, if you'd like to run it, you can do so with the following command: | ||
|
||
> Make sure to install gotestsum by running: `go install gotest.tools/gotestsum@latest` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a windows_dev.md file to the docs folder. This file is supposed to help Windows devs navigate the development of buildkit on Windows. This 1st version adds documentation on how to run and debug integration tests. Signed-off-by: Daniel Githinji <[email protected]> Signed-off-by: Daniel Githinji <[email protected]>
3e161da
to
82f671a
Compare
This PR adds a windows_dev.md file to the docs folder. This file contains documentation to help buildkit developers navigate the development of buildkit on Windows. This 1st version adds documentation on how to run integration tests.