Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: list supported algorithms for ADD --checksum #5237

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Aug 10, 2024

@dvdksn dvdksn changed the title docs: list supported algorithsm for ADD --checksum docs: list supported algorithms for ADD --checksum Aug 10, 2024
@crazy-max crazy-max merged commit 664c2b4 into moby:master Aug 10, 2024
19 checks passed
@thaJeztah
Copy link
Member

@crazy-max Are there still improvements to be made to the error message as well? (I haven't checked); see the original ticket;

I'd add to better document the error you get when the digest algorithm is unsupported. I tried ADD --checksum:md5 and the error I was getting from a docker compose build command was "unsupported digest algorithm", which IMO is not very clear. I didn't even know it was about the ADD command, and I was digging around the image digest for a good bit before thinking of looking at the ADD command.

@crazy-max
Copy link
Member

@crazy-max Are there still improvements to be made to the error message as well? (I haven't checked); see the original ticket;

I'd add to better document the error you get when the digest algorithm is unsupported. I tried ADD --checksum:md5 and the error I was getting from a docker compose build command was "unsupported digest algorithm", which IMO is not very clear. I didn't even know it was about the ADD command, and I was digging around the image digest for a good bit before thinking of looking at the ADD command.

Good point we could improve the error message indeed

@dvdksn dvdksn deleted the add-checksum-algorithms branch August 10, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document supported checksum digest algorithm
3 participants