ci: fix docs upstream validation workflow #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Karlsson <[email protected]>
dvdksn
force-pushed
the
fix-docs-upstream-workflow
branch
from
0a3d9bf
to
682b66d
Compare
|
close/open the PR to trigger the workflow that was disabled. |
crazy-max
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
LGTM
@dvdksn In follow-up could you disable mode=max for gha cache export in the reusable workflow? https://github.com/moby/buildkit/actions/runs/6539953635/job/17759393799#step:6:532
#30 writing layer sha256:dcd3b03f5dc4c271c4a72c70bb3c27afea4359321210ac3d6a05a1ea5fd0711f 1.7s done
#30 writing layer sha256:ebb3fe13ab0e8f69bb60d0955ac4408e2ff7b0a49f75f7d15a98c4242ceb3a06 0.1s done
#30 preparing build cache for export 169.3s done
#30 DONE 169.3s
It takes more time to export cache than running the build.
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Karlsson [email protected]