Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump user agent version #75

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

technillogue
Copy link
Contributor

@technillogue technillogue commented Oct 6, 2022

stories dropped and Signal-Android/5.22.3 now seems to get DeprecatedVersionException

cxloe
cxloe previously approved these changes Oct 10, 2022
Copy link
Contributor

@cxloe cxloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thank you!

@@ -19,7 +19,7 @@ auxin_protos = { path = "../auxin_protos" }

#Signal protocol & zero knowledge proof stuff.
libsignal-protocol = { git = "https://github.com/signalapp/libsignal-client", tag = "v0.14.0"}
zkgroup = { git = "https://github.com/signalapp/zkgroup", tag = "v0.9.0" }
zkgroup = { git = "https://github.com/signalapp/libsignal-client" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this find zkgroup in that repo?

@cxloe cxloe dismissed their stale review October 11, 2022 21:29

zkgroup change breaks things "perhaps two different versions of crate curve25519_dalek are being used?"

@cxloe cxloe self-requested a review November 20, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants