-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConstantTimeEq proc macro derive #302
Conversation
268d755
to
0cd6970
Compare
Codecov Report
@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 88.24% 90.50% +2.25%
==========================================
Files 47 48 +1
Lines 4466 5611 +1145
==========================================
+ Hits 3941 5078 +1137
- Misses 525 533 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
❌ Unreviewed dependencies found
|
b5d192a
to
850018f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
submitting without specific approval/denial since I'll be awol for the next couple of weeks
062ec20
to
73ed79b
Compare
338e5aa
to
c3c6b15
Compare
9a1448c
to
e168b22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main thing that should be done is mapping the ==
to Choice in the enum derive logic.
the other stuff is mainly nits and suggestions
3c76ebf
to
8e5b286
Compare
closing due to shifting focus |
Motivation
Fixes #280
Using Subtle crate
Implemented ConstantTimeEq using proc macro derive
Implemented ConstantTimeGreater and ConstantTimeLesser
Future Work
Move proc macro into subtle crate