Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tonic and message rust generation #7

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

No description provided.

@nick-mobilecoin nick-mobilecoin requested a review from a team as a code owner February 14, 2023 00:04
@nick-mobilecoin nick-mobilecoin requested review from awygle and samdealy and removed request for a team February 14, 2023 00:04
@github-actions github-actions bot added the size/XL Extra-Large PRs label Feb 14, 2023
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Feb 14, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the rust Changes to rust code or dependencies label Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #7 (7bdaec9) into main (dfc282a) will decrease coverage by 99.02%.
The diff coverage is 0.98%.

❗ Current head 7bdaec9 differs from pull request most recent head 6ead82c. Consider uploading reports for the commit 6ead82c to get more accurate results

@@             Coverage Diff             @@
##              main      #7       +/-   ##
===========================================
- Coverage   100.00%   0.98%   -99.02%     
===========================================
  Files            3       6        +3     
  Lines           15     306      +291     
===========================================
- Hits            15       3       -12     
- Misses           0     303      +303     
Impacted Files Coverage Δ
.../src/mobilecoinfoundation.attestation.v1.grpcio.rs 0.00% <0.00%> (ø)
...essages/src/mobilecoinfoundation.attestation.v1.rs 0.00% <0.00%> (ø)
...c/src/mobilecoinfoundation.attestation.v1.tonic.rs 0.00% <0.00%> (ø)
mobilecoinfoundation/attestation/grpcio/src/lib.rs 100.00% <100.00%> (ø)
...bilecoinfoundation/attestation/messages/src/lib.rs 100.00% <100.00%> (ø)
mobilecoinfoundation/attestation/tonic/src/lib.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin
Copy link
Collaborator Author

Moving to draft to generate the files at build time.

@nick-mobilecoin nick-mobilecoin marked this pull request as draft February 14, 2023 18:38
Base automatically changed from nick/rust-ci to main February 14, 2023 23:47
@github-actions github-actions bot added size/L Large PRs github_actions Changes to github actions or dependencies and removed size/XL Extra-Large PRs labels Feb 15, 2023
@nick-mobilecoin nick-mobilecoin changed the title Add generated rust modules Add tonic and message rust generation Feb 15, 2023
Add build steps to generate the attestation tonic services and messages
@nick-mobilecoin nick-mobilecoin marked this pull request as ready for review February 15, 2023 17:01
Copy link

@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Feb 16, 2023

✅ This pull request merged successfully as part of a Graphite job
Job ID: V6Mxxs7OfGV7GPJbCBGI.
See details on graphite.dev

@nick-mobilecoin nick-mobilecoin merged commit 65ae25f into main Feb 16, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/rust-modules branch February 16, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Changes to github actions or dependencies rust Changes to rust code or dependencies size/L Large PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants