Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Attributes verification from MobileCoin repo #3

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

No description provided.

@nick-mobilecoin nick-mobilecoin requested a review from a team as a code owner February 17, 2023 16:28
@nick-mobilecoin nick-mobilecoin requested review from jcape and varsha888 and removed request for a team February 17, 2023 16:28
@github-actions github-actions bot added the rust Pull requests that update rust code label Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #3 (0f4f9a5) into nick/generic-and-or (3226aa8) will increase coverage by 0.92%.
The diff coverage is 96.66%.

❗ Current head 0f4f9a5 differs from pull request most recent head 21e411c. Consider uploading reports for the commit 21e411c to get more accurate results

@@                   Coverage Diff                   @@
##           nick/generic-and-or       #3      +/-   ##
=======================================================
+ Coverage                93.54%   94.47%   +0.92%     
=======================================================
  Files                        1        2       +1     
  Lines                      124      181      +57     
=======================================================
+ Hits                       116      171      +55     
- Misses                       8       10       +2     
Impacted Files Coverage Δ
verifier/src/report_body.rs 96.49% <96.49%> (ø)
verifier/src/lib.rs 93.54% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jcape jcape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but my strong opinion is that we will need to supply the full Evidence to everything if we want to have this built off a string / use And+Or.

verifier/src/report_body.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update rust code size/L Large PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants