Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open link e2e test #2058

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

tokou
Copy link
Contributor

@tokou tokou commented Sep 16, 2024

Proposed changes

  • Add an E2E test showcasing openLink behavior on the demo app

Testing

  • Run the e2e scenario on an Android emulator

Issues fixed

Linked comment #1999 (comment)
Linked PR mobile-dev-inc/demo_app#4


- openLink: 'https://maestro.mobile.dev'
- assertVisible:
id: 'signin_fre_dismiss_button|send_report_checkbox|terms_accept'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this asserting? I'm unclear why this isn't the docs.
On that point, is it worth a comment for future people maintaining this test?

@Fishbowler
Copy link
Contributor

Argh. #2085 (a revert of #1999 that was merged before this branch) has given this conflicts.
Can this be fixed, or does this work depend on #1999?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants