Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional field from selectors #2014

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Conversation

bartekpacia
Copy link
Contributor

@bartekpacia bartekpacia commented Sep 4, 2024

The selector-level optional argument has been superseded by the command-level optional argument in #1946.

This PR is a follow up of #1946 (specifically, this comment)

@bartekpacia bartekpacia marked this pull request as ready for review September 4, 2024 18:54
@bartekpacia
Copy link
Contributor Author

bartekpacia commented Sep 6, 2024

(for @mobile-dev-inc employees only)

I did a quick search of "optional" in our monorepo (LINK). Didn't find many usages.

The list of Maestro commands visible in this view:

Screenshot 2024-09-06 at 15 10 14

is returned by GetLiveScanRoute (example url: https://api.mobile.dev/scan/5e53f184-7cca-4239-b756-5497cb23f538)

Rollout action items

@bartekpacia bartekpacia merged commit 21edc14 into main Sep 6, 2024
6 checks passed
@bartekpacia bartekpacia deleted the optional_arg_testing branch September 6, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants