-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests across a range of JDKs #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will probably fail because of Android SDK tools requiring Java 17. Therefore to make this work I will take the same approach as in Masetro:
EDIT The above approach turned out to be problematic because of this: Lines 44 to 63 in 8410d5a
not wanting to spend too much time on it, I went the other way: just fix all NoSuchMethodErrors – turns out there were only 2 such places. |
bartekpacia
force-pushed
the
ci/upgrade
branch
from
September 3, 2024 21:41
150072f
to
f2f0e6b
Compare
bartekpacia
force-pushed
the
ci/upgrade
branch
from
September 6, 2024 10:30
d470a91
to
3dd68aa
Compare
bartekpacia
force-pushed
the
ci/upgrade
branch
from
September 6, 2024 12:21
6d6940a
to
d7bf970
Compare
This reverts commit d7bf970.
…ElementException: Discovered unresolved method during parsing: java.nio.ByteBuffer.clear()
bartekpacia
force-pushed
the
ci/upgrade
branch
2 times, most recently
from
September 6, 2024 15:08
ac45f06
to
b3685c8
Compare
bartekpacia
force-pushed
the
ci/upgrade
branch
from
September 6, 2024 15:17
b3685c8
to
b2be6d6
Compare
Leland-Takamine
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up/follow-up of Igor's PR here