Skip to content

Commit

Permalink
Add more owncloud/nextcloud client headers
Browse files Browse the repository at this point in the history
Adds some additional ownCloud/NextCloud client headers relating to mnutt/davros#114.

The new headers:
* `oc-checksum` - a hash (typically `SHA1`) of the entire file. After all chunks have been uploaded, davros should be checking this to ensure that it uploaded correctly, otherwise we may end up saving a corrupted file. [this header has been around for a while, I should have been doing this all along]
* `oc-chunk-offset` - part of a new chunking scheme. Right now the legacy chunking scheme relies on all chunks being the same size in order to calculate the offset (number * chunkSize); this header would allow the client to vary the chunk size based on timing/bandwidth.
* `oc-lazyops` - I'm unlikely to implement this soon, but it would be a way for the client to signal "I don't want to wait for a response". The server would then hypothetically respond with a location where the client could poll for progress updates.
  • Loading branch information
mnutt authored Aug 17, 2021
1 parent 36a6d46 commit 88b834b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/sandstorm/web-session.capnp
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ interface WebSession @0xa50711a14d35a8ce extends(Grain.UiSession) {
"x-oc-mtime", # Owncloud client
"oc-fileid", # Owncloud client
"oc-chunked", # Owncloud client
"oc-checksum", # Owncloud client
"oc-chunk-offset", # Owncloud client
"oc-lazyops", # Owncloud client
"x-hgarg-*", # Mercurial client
"x-phabricator-*", # Phabricator
"x-requested-with", # JQuery header used by Rails and other frameworks
Expand Down

0 comments on commit 88b834b

Please sign in to comment.