[FIX] Reading an EDF with preload=False and mixed frequency #13069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjerns
requested review from
larsoner,
drammock,
agramfort and
dengemann
as code owners
larsoner
approved these changes
Jan 17, 2025
|
I know it unrelated, but to get things green could you add Line 188 in 087779c ? |
|
Never mind I pushed... marking for merge-when-green, thanks in advance @skjerns ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12897.
When loading an EDF with mixed sample frequencies and using
preload=Falseand then requesting a channel that has lower sample frequency than the maximum resulted in anAssertionError.What does this implement/fix?
This Assertion was in place to make sure that enough samples were read, but only made sense when one of the channels of maximum sample frequency was loaded.
It can simply be removed as I don't think that the case can actually occur. Additionally, there is another check for zeros a few lines later that serves a similar purpose.