Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fNIRS #960

Closed
wants to merge 3 commits into from
Closed

Add support for fNIRS #960

wants to merge 3 commits into from

Conversation

rob-luke
Copy link
Member

PR Description

This PR replaces #406

This PR adds support for fNIRS. There is a BEP in progress for NIRS support here... bids-standard/bids-specification#802

The BEP is in the final stages. We are writing the manuscript up. The spec has been stable for a long time and is implemented in other software (Homer)

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #960 (d14a30b) into main (81bccd6) will not change coverage.
The diff coverage is n/a.

❗ Current head d14a30b differs from pull request most recent head 1f82fb8. Consider uploading reports for the commit 1f82fb8 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          25       25           
  Lines        3583     3583           
=======================================
  Hits         3387     3387           
  Misses        196      196           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81bccd6...1f82fb8. Read the comment docs.

@rob-luke
Copy link
Member Author

Closed in favor of original PR thanks to git magic from larsoner

@rob-luke rob-luke closed this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant