add javadoc and clean up unused imports

mnagaya · Jun 25, 2019 · fe27d58 · fe27d58
1 parent 4b56d4b
commit fe27d58
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Application.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Application.java
@@ -5,11 +5,9 @@
 import com.yahoo.component.Version;
 import com.yahoo.config.application.api.DeploymentSpec;
 import com.yahoo.config.application.api.ValidationOverrides;
-import com.yahoo.config.model.api.ContainerEndpoint;
 import com.yahoo.config.provision.ApplicationId;
 import com.yahoo.config.provision.Environment;
 import com.yahoo.config.provision.HostName;
-import com.yahoo.config.provision.RotationName;
 import com.yahoo.config.provision.SystemName;
 import com.yahoo.config.provision.zone.ZoneId;
 import com.yahoo.vespa.hosted.controller.api.integration.MetricsService.ApplicationMetrics;
@@ -21,26 +19,21 @@
 import com.yahoo.vespa.hosted.controller.application.Change;
 import com.yahoo.vespa.hosted.controller.application.Deployment;
 import com.yahoo.vespa.hosted.controller.application.DeploymentJobs;
-import com.yahoo.vespa.hosted.controller.application.Endpoint;
 import com.yahoo.vespa.hosted.controller.application.EndpointList;
 import com.yahoo.vespa.hosted.controller.application.RotationStatus;
-import com.yahoo.vespa.hosted.controller.rotation.Rotation;
 import com.yahoo.vespa.hosted.controller.rotation.RotationId;
 
 import java.time.Instant;
 import java.util.Collections;
 import java.util.Comparator;
-import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
 import java.util.OptionalInt;
 import java.util.OptionalLong;
-import java.util.Set;
 import java.util.function.Function;
 import java.util.stream.Collectors;
-import java.util.stream.Stream;
 
 /**
  * An instance of an application.

diff --git a/...roller-server/src/main/java/com/yahoo/vespa/hosted/controller/application/EndpointId.java b/...roller-server/src/main/java/com/yahoo/vespa/hosted/controller/application/EndpointId.java
@@ -2,6 +2,12 @@
 
 import java.util.Objects;
 
+/**
+ * A type to represent the ID of an endpoint.  This is typically the first part of
+ * an endpoint name.
+ *
+ * @author ogronnesby
+ */
 public class EndpointId {
     private static final EndpointId DEFAULT = new EndpointId("default");
 

diff --git a/...er/src/main/java/com/yahoo/vespa/hosted/controller/persistence/ApplicationSerializer.java b/...er/src/main/java/com/yahoo/vespa/hosted/controller/persistence/ApplicationSerializer.java
@@ -7,7 +7,6 @@
 import com.yahoo.config.provision.ApplicationId;
 import com.yahoo.config.provision.ClusterSpec;
 import com.yahoo.config.provision.HostName;
-import com.yahoo.document.datatypes.Array;
 import com.yahoo.slime.ArrayTraverser;
 import com.yahoo.slime.Cursor;
 import com.yahoo.slime.Inspector;

diff --git a/...rver/src/test/java/com/yahoo/vespa/hosted/controller/rotation/RotationRepositoryTest.java b/...rver/src/test/java/com/yahoo/vespa/hosted/controller/rotation/RotationRepositoryTest.java
@@ -15,7 +15,6 @@
 
 import java.net.URI;
 import java.util.List;
-import java.util.Optional;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;