Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes first blog post (a WASM deployment) #11

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

mmurray22
Copy link
Owner

@mmurray22 mmurray22 commented Jun 27, 2020

This PR relates to the first "blog post", which centers around a Rust program deployed to the web using Web Assembly. Let me know if this needs to be made smaller (all the files included in this PR were essential for it to contain a working product, but if this needs to be subdivided more, let me know!)

@mmurray22 mmurray22 requested review from ccondit and kaveh096 June 27, 2020 00:43
@@ -0,0 +1,23 @@
// The wasm-pack uses wasm-bindgen to build and generate JavaScript binding file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no idea what this file is and what it' supposed to do. sorry.

use wasm_bindgen::prelude::*;

#[wasm_bindgen]
pub fn ops(a:i32, b:i32, op:String) -> i32 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add unit tests to rust files?

Copy link
Contributor

@ccondit ccondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR includes a mixed bag of formatting / parallax / link changes still.

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 0 24 24" width="24"><path d="M0 0h24v24H0V0z" fill="none"/><path d="M20 4H4c-1.1 0-1.99.9-1.99 2L2 18c0 1.1.9 2 2 2h16c1.1 0 2-.9 2-2V6c0-1.1-.9-2-2-2zm-.4 4.25l-7.07 4.42c-.32.2-.74.2-1.06 0L4.4 8.25c-.25-.16-.4-.43-.4-.72 0-.67.73-1.07 1.3-.72L12 11l6.7-4.19c.57-.35 1.3.05 1.3.72 0 .29-.15.56-.4.72z"/></svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop these images out of this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants