Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS 12 #163

Merged
merged 2 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
strategy:
matrix:
node-version: [ 16.x, 18.x, 20.x, 21.x ]
platforms: [ windows-2019, macos-11 ]
platforms: [ windows-2019, macos-12 ]

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:

test_mac:

runs-on: macos-11
runs-on: macos-12

strategy:
matrix:
Expand Down Expand Up @@ -186,7 +186,7 @@ jobs:

test_mac_debug:

runs-on: macos-11
runs-on: macos-12

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
platforms: [ ubuntu-20.04, ubuntu-22.04, windows-2019, macos-11 ]
platforms: [ ubuntu-22.04, ubuntu-24.04, windows-2019, macos-12 ]
node-version: [ 16.x, 18.x, 20.x, 21.x ]

steps:
Expand Down Expand Up @@ -48,7 +48,7 @@ jobs:

strategy:
matrix:
platforms: [ ubuntu-20.04, ubuntu-22.04, windows-2019, macos-11 ]
platforms: [ ubuntu-22.04, ubuntu-24.04, windows-2019, macos-12 ]
node-version: [ 16.x, 18.x, 20.x, 21.x ]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:

strategy:
matrix:
platforms: [ windows-2019, macos-11 ]
platforms: [ windows-2019, macos-12 ]
node-version: [ 16.x, 18.x, 20.x, 21.x ]

steps:
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- All shared library symbols are now hidden on Linux, allowing to load the binary addon in a process that has loaded a different version of GDAL (on Windows this has always been possible and on maOS, while possible in theory, this particular linking mode is not supported by `node-gyp`)

### Removed
- Drop macOS 11 support


## [3.8.5] 2024-04-09

Expand Down
4 changes: 2 additions & 2 deletions test/api_rasterband.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ describe('gdal.RasterBand', () => {
assert.equal(data[10 * 20 + 10], 10)
})
describe('w/data over 4GB', function () {
this.timeout(30000)
this.timeout(60000)
// These tests require at least 16GB of memory to be reliable
const size = 66000
it('when returning a new TypedArray', () => {
Expand Down Expand Up @@ -1096,7 +1096,7 @@ describe('gdal.RasterBand', () => {
}
})
it('should not fail when writing more than 4GB', function () {
this.timeout(30000)
this.timeout(60000)
if (semver.lt(gdal.version, '3.6.0')) {
this.skip()
}
Expand Down