Add Avatar Client to Examples #67 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the avatar one Updated examples and content for the new structure Added basic example with avatar for mmlCollisionStart TODO: Refactor ExampleClient and ExampleAvatarClient to get rid of duplicate code
✅ Deploy Preview for mml-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Limited the number of clients to 4 Moved client creation to the top bar of Example View Add a button to close individual clients Fixed client references/id to close the right client when clicking on it Changed base scene to be set on example client with three.js instead of the code passed down to all clients Create new components for some of the sections Some renaming Added FontAwesome icons
…necessary Refactored m-light examples to avoid conflicts with avatar client
Made sure ids can't be reassigned Made avatar spawn in different places
Refactored code to use the aforementioned utility Fixed errors happening on ExamplePageExampleView.tsx
Fixed bug happening on events because of missing div
MarcusLongmuir
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles #67 (though not all of it)
Modified the example view to show either the floating camera client or the avatar one
Updated examples and content for the new structure
Added basic example with avatar for mmlCollisionStart
What kind of change does your PR introduce? (check at least one)
Does your PR fulfill the following requirements?