Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updatable client config (#167) #171

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

MarcusLongmuir
Copy link
Contributor

@MarcusLongmuir MarcusLongmuir commented Aug 2, 2024

Resolves #167.

This PR:

  • Makes the part of the configuration of the Networked3dWebExperienceClient updatable. The config that is updatable is defined by the UpdatableConfig type.
  • Breaking change - The skyboxHdrJpgUrl is replaced by environmentConfig.hdrJpgUrl and environmentConfig.hdrUrl
  • Breaking change - The mmlDocuments config is now an object with keys that allow updates to the config to ensure that existing documents are diffed correctly (by their consistent key from old -> new config).
  • Broadcast sending and receiving have been added to the UserNetworkingServer and UserNetworkingClient classes to allow sending arbitrary messages from the server to the connected clients (e.g. to allow sending a config update from the server to the client).

An example that sends a broadcast to connected clients can be found on the feature/update-world-config-example branch.

What kind of change does your PR introduce? (check at least one)

  • Feature

Does your PR fulfill the following requirements?

  • The title references the corresponding issue # (if relevant)

@MarcusLongmuir MarcusLongmuir force-pushed the feature/update-world-config branch from 30a3d56 to 454a0ca Compare August 5, 2024 09:45
@MarcusLongmuir MarcusLongmuir marked this pull request as ready for review August 5, 2024 10:30
@MarcusLongmuir MarcusLongmuir force-pushed the feature/update-world-config branch from 454a0ca to 76312d0 Compare August 5, 2024 10:30
@TheCodeTherapy TheCodeTherapy merged commit eff4f77 into main Aug 5, 2024
5 checks passed
@TheCodeTherapy TheCodeTherapy deleted the feature/update-world-config branch August 5, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live config reloading
2 participants