implements variable and double jumps and pane control settings #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Object.values(this.animations).forEach((action) => { | ||
| action.stop(); | ||
| }); | ||
| this.preventDoubleJump = true; |
There was a problem hiding this comment.
It took me a while to figure out what this was doing. If I understand correctly it's stopping the handling of a change back to AnimationState.doubleJump after the animation has played so that even though the controller is declaring the animation state is AnimationState.doubleJump the air animation isn't overridden. This was confusing to say the least 😅
MarcusLongmuir
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
What kind of change does your PR introduce? (check at least one)
Does your PR fulfill the following requirements?
2024-05-20.19-29-01.mp4