Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visual improvements #108

Merged
merged 16 commits into from
Feb 8, 2024
Merged

visual improvements #108

merged 16 commits into from
Feb 8, 2024

Conversation

TheCodeTherapy
Copy link
Contributor

This PR aims to offer several visual improvements to the 3d-web-experience.

What kind of change does your PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Refactor
  • Tests
  • Other, please describe:

Does your PR fulfill the following requirements?

  • The title references the corresponding issue # (if relevant)
visual_improvements.mp4

@@ -29,7 +29,7 @@ import {
} from "mml-web";
import { AudioListener, Euler, Scene, Vector3 } from "three";

import hdrUrl from "../../assets/hdr/industrial_sunset_2k.hdr";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this file isn't used any more we should remove it to clean up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@TheCodeTherapy TheCodeTherapy merged commit ad4b20a into main Feb 8, 2024
5 checks passed
@deej-io deej-io deleted the feature/visual-improvements branch August 5, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants