Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves character occlusion prevention to avoid surfaces clipping #106

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

TheCodeTherapy
Copy link
Contributor

This PR aims to improve the CameraManager character occlusion prevention method to prevent the clipping of surfaces when the camera position needs to be readjusted by the adjustCameraPosition method. It also improves the FoV per camera distance mapping to improve 1st person view.

What kind of change does your PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Refactor
  • Tests
  • Other, please describe:

Does your PR fulfill the following requirements?

  • The title references the corresponding issue # (if relevant)
before_after.mp4

@MarcusLongmuir MarcusLongmuir merged commit 0d0c89d into main Feb 6, 2024
5 checks passed
@MarcusLongmuir MarcusLongmuir deleted the fix/surfaces-clipping branch February 6, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants