m-character sockets #105
Merged
m-character sockets #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCodeTherapy
force-pushed
the
feature/m-character-sockets
branch
from
ba9f3a2 to
748e665
Compare
|
|
||
| private async setAttachments(parts: MMLCharacterDescriptionPart[]): Promise<void> { | ||
| parts.forEach(async (part) => { | ||
| if (part.socket?.socket && this.availableBones.has(part.socket.socket)) { |
There was a problem hiding this comment.
I think this should handle the case where there isn't a valid bone by adding it to the root (which is effectively between the feet)
There was a problem hiding this comment.
@MarcusLongmuir Nice catch! Fixed (I'm console.warning it though).
TheCodeTherapy
force-pushed
the
feature/m-character-sockets
branch
from
3da6a43 to
073bd42
Compare
MarcusLongmuir
force-pushed
the
feature/m-character-sockets
branch
from
0c6679f to
d89224a
Compare
MarcusLongmuir
force-pushed
the
feature/m-character-sockets
branch
from
d89224a to
5a7b737
Compare
MarcusLongmuir
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to offer further character customization to the
3d-web-experiencethrough the usage of them-characterMML Character Descriptions tag with nestedm-modeltags including thesocketattribute.What kind of change does your PR introduce? (check at least one)
Does your PR fulfill the following requirements?