Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mml character loading #104

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Refactor mml character loading #104

merged 1 commit into from
Feb 1, 2024

Conversation

MarcusLongmuir
Copy link
Contributor

This PR refactors how and where the character loading (from either mesh GLB or MML url / string) takes place.

This:

  • Avoids a race condition where the character would not be created until the loading had completed, and (an extremely unlikely) race condition that the remote character would attempt to use the characterDescription before it had been augmented by the local loading
  • Makes it clearer how to implement per-user character descriptions

What kind of change does your PR introduce? (check at least one)

  • Refactor

@TheCodeTherapy TheCodeTherapy merged commit c33d9eb into main Feb 1, 2024
5 checks passed
@deej-io deej-io deleted the bugfix/character-load-refactor branch August 5, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCodeTherapy TheCodeTherapy TheCodeTherapy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcusLongmuir @TheCodeTherapy