Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box small integers as Longs like Clojure, not Integers like .getNumberValue() #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

w01fe
Copy link

@w01fe w01fe commented Apr 14, 2013

This is consistent with the way that Clojure handles small integers, and can avoid unexpected issues downstream when you attempt to, e.g., use these numbers as keys in a HashMap and then look them up with Clojure integer literals.

I guess it's technically a breaking change, but it didn't break the tests, and Clojure itself has waffled a bit on this sort of behavior without much hubbub (e.g., (int 2) produced an Integer in Clojure 1.0, then a Long in Clojure 1.3, then an Integer again in 1.4, if my memory serves me right).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant