Adding a case for END_ARRAY in JsonExt. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be parsed even if the sequence is nested inside a larger JSON structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using clj-json to parse very large amounts of JSON (>1Gb) so it's very useful to have access to Jackson via clj-json, and laziness is critical, so parsed-seq* is very useful (and more so if it were public!). However, at the end of a large lazy sequence within a large JSON structure, the END_ARRAY token causes a "Cannot parse" exception to be thrown from JsonExt. This amendment is unlikely to have compatibility issues unless users were handling this exception in their logic. I think the overall benefit of this change to those like me who need to parse very large datasets makes it worthwhile - so please consider merging this.