-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Datasets README.md to clarify dataset contribution workflow #26
Conversation
WalkthroughThe changes in the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
src/MEDS_DEV/datasets/README.md (2)
4-8
: Excellent addition, with minor suggestions for improvement.The new section on contributing a dataset is clear and helpful. To further enhance it, consider the following suggestions:
- In step 3, provide more specific instructions on how to test locally, or link to a testing guide if one exists.
- In step 2, mention the naming convention for the dataset predicates file (if there is one).
- In step 4, consider adding a link to GitHub's documentation on creating pull requests for new contributors.
Example:
3. Test locally to ensure your dataset works correctly (refer to our testing guide [link]) 4. Create a pull request with your changes (see GitHub's guide on [creating a pull request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request))
11-14
: Good reformatting, with suggestions for clarity.The reformatted notes section is more readable. To further improve it, consider:
Making the introductory sentence more concise. For example:
If you need a more specialized task configuration file than can be achieved by overwriting predicates:Providing more detail in step 1 about creating a GitHub issue. For example:
1. Create a GitHub issue explaining why the existing file is insufficient and what specialized configuration is neededThese changes would make the instructions even clearer for contributors.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- src/MEDS_DEV/datasets/README.md (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
src/MEDS_DEV/datasets/README.md (1)
1-14
: Overall, excellent improvements to the README.The changes successfully clarify the process for collaborators to add their dataset predicates, which aligns well with the PR objectives. The new section on contributing datasets and the reformatted notes significantly enhance the documentation's clarity and usefulness. With the minor suggestions provided, this update will greatly assist contributors in understanding and following the correct procedures.
Clarified how collaborates should add their dataset predicates to the repo.
Summary by CodeRabbit
New Features
Documentation