Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCLA DATA Predicates file #23

Merged
merged 9 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
197 changes: 197 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -160,3 +160,200 @@ cython_debug/
.idea/

.editorconfig


# Created by https://www.toptal.com/developers/gitignore/api/macos,pycharm,visualstudiocode,windows
# Edit at https://www.toptal.com/developers/gitignore?templates=macos,pycharm,visualstudiocode,windows

### macOS ###
# General
.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon


# Thumbnails
._*

# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent

# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk

### macOS Patch ###
# iCloud generated files
*.icloud

### PyCharm ###
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio, WebStorm and Rider
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839

# User-specific stuff
.idea/**/workspace.xml
.idea/**/tasks.xml
.idea/**/usage.statistics.xml
.idea/**/dictionaries
.idea/**/shelf

# AWS User-specific
.idea/**/aws.xml

# Generated files
.idea/**/contentModel.xml

# Sensitive or high-churn files
.idea/**/dataSources/
.idea/**/dataSources.ids
.idea/**/dataSources.local.xml
.idea/**/sqlDataSources.xml
.idea/**/dynamic.xml
.idea/**/uiDesigner.xml
.idea/**/dbnavigator.xml

# Gradle
.idea/**/gradle.xml
.idea/**/libraries

# Gradle and Maven with auto-import
# When using Gradle or Maven with auto-import, you should exclude module files,
# since they will be recreated, and may cause churn. Uncomment if using
# auto-import.
# .idea/artifacts
# .idea/compiler.xml
# .idea/jarRepositories.xml
# .idea/modules.xml
# .idea/*.iml
# .idea/modules
# *.iml
# *.ipr

# CMake
cmake-build-*/

# Mongo Explorer plugin
.idea/**/mongoSettings.xml

# File-based project format
*.iws

# IntelliJ
out/

# mpeltonen/sbt-idea plugin
.idea_modules/

# JIRA plugin
atlassian-ide-plugin.xml

# Cursive Clojure plugin
.idea/replstate.xml

# SonarLint plugin
.idea/sonarlint/

# Crashlytics plugin (for Android Studio and IntelliJ)
com_crashlytics_export_strings.xml
crashlytics.properties
crashlytics-build.properties
fabric.properties

# Editor-based Rest Client
.idea/httpRequests

# Android studio 3.1+ serialized cache file
.idea/caches/build_file_checksums.ser

### PyCharm Patch ###
# Comment Reason: https://github.com/joeblau/gitignore.io/issues/186#issuecomment-215987721

# *.iml
# modules.xml
# .idea/misc.xml
# *.ipr

# Sonarlint plugin
# https://plugins.jetbrains.com/plugin/7973-sonarlint
.idea/**/sonarlint/

# SonarQube Plugin
# https://plugins.jetbrains.com/plugin/7238-sonarqube-community-plugin
.idea/**/sonarIssues.xml

# Markdown Navigator plugin
# https://plugins.jetbrains.com/plugin/7896-markdown-navigator-enhanced
.idea/**/markdown-navigator.xml
.idea/**/markdown-navigator-enh.xml
.idea/**/markdown-navigator/

# Cache file creation bug
# See https://youtrack.jetbrains.com/issue/JBR-2257
.idea/$CACHE_FILE$

# CodeStream plugin
# https://plugins.jetbrains.com/plugin/12206-codestream
.idea/codestream.xml

# Azure Toolkit for IntelliJ plugin
# https://plugins.jetbrains.com/plugin/8053-azure-toolkit-for-intellij
.idea/**/azureSettings.xml

### VisualStudioCode ###
.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json
!.vscode/*.code-snippets

# Local History for Visual Studio Code
.history/

# Built Visual Studio Code Extensions
*.vsix

### VisualStudioCode Patch ###
# Ignore all local history of files
.history
.ionide

### Windows ###
# Windows thumbnail cache files
Thumbs.db
Thumbs.db:encryptable
ehthumbs.db
ehthumbs_vista.db

# Dump file
*.stackdump

# Folder config file
[Dd]esktop.ini

# Recycle Bin used on file shares
$RECYCLE.BIN/

# Windows Installer files
*.cab
*.msi
*.msix
*.msm
*.msp

# Windows shortcuts
*.lnk

# End of https://www.toptal.com/developers/gitignore/api/macos,pycharm,visualstudiocode,windows
16 changes: 16 additions & 0 deletions src/MEDS_DEV/datasets/UCLA/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# UCLA Datasets

This folder contains details for datasets currently included in the MEDS-DEV effort.

TODO: More details.

Tasks TODO:

- Long Admission
- ICU Mortality
- Hypotension
- Elevated Creatine
- Hyponatremia
- Metabolic Acidosis
- Leukocytosis
- Thrombocytopenia
51 changes: 51 additions & 0 deletions src/MEDS_DEV/datasets/UCLA/anemia.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
description: >-
This task predicts whether the patient will have abnormal _hemoglobin_ values within a 24-hour window for a given patient.
To be included, patients must have at least one measurement for hemoglobin within a given 24-hour period in the labs table
at UCLA.

predicates:
labs:
code: { regex: "^LABS//.*" }

# Plain predicates for hemoglobin
hemoglobin_1:
code: LAB//220228//g/dl
hemoglobin_2:
code: LAB//50811//g/dL

abnormal_hemoglobin_1:
code: LAB//220228//g/dl
value_min: null
value_max: 13
value_max_inclusive: False
abnormal_hemoglobin_2:
code: LAB//50811//g/dL
value_min: null
value_max: 13
value_max_inclusive: False

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider using YAML anchors to reduce predicate duplication.

The abnormal hemoglobin predicates share identical configuration except for the code. Consider using YAML anchors to reduce duplication and maintain consistency.

+  # Define the base abnormal configuration
+  abnormal_config: &abnormal_base
+    value_min: null
+    value_max: 13
+    value_max_inclusive: False
+
   abnormal_hemoglobin_1:
     code: LAB//220228//g/dl
-    value_min: null
-    value_max: 13
-    value_max_inclusive: False
+    <<: *abnormal_base
   abnormal_hemoglobin_2:
     code: LAB//50811//g/dL
-    value_min: null
-    value_max: 13
-    value_max_inclusive: False
+    <<: *abnormal_base
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
abnormal_hemoglobin_1:
code: LAB//220228//g/dl
value_min: null
value_max: 13
value_max_inclusive: False
abnormal_hemoglobin_2:
code: LAB//50811//g/dL
value_min: null
value_max: 13
value_max_inclusive: False
# Define the base abnormal configuration
abnormal_config: &abnormal_base
value_min: null
value_max: 13
value_max_inclusive: False
abnormal_hemoglobin_1:
code: LAB//220228//g/dl
<<: *abnormal_base
abnormal_hemoglobin_2:
code: LAB//50811//g/dL
<<: *abnormal_base

# Combining the hemoglobin predicates
hemoglobin:
expr: or(hemoglobin_1, hemoglobin_2)
abnormal_hemoglobin:
expr: or(abnormal_hemoglobin_1, abnormal_hemoglobin_2)

trigger: lab_start

windows:
input:
start: trigger
end: trigger + 24h
start_inclusive: True
end_inclusive: True
index_timestamp: end
has:
hemoglobin: (1, None)
target:
start: input.end
end: start + 24h
start_inclusive: False
end_inclusive: True
has:
hemoglobin: (1, None)
label: abnormal_hemoglobin
Loading