Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases and (eventually) fixes for #114 #116

Closed
wants to merge 148 commits into from

Conversation

mmcdermott
Copy link
Owner

STILL IN PROGRESS. We just have failing test cases for now.

Removed the old increment calls to assign event IDs in favor of hashes of subject IDs and timestamps which can be run lazily.
…_flat_reps

Add computation over future summary windows to flat reps
Fixes the slowdowns and bugs caused by the prior improved compute practices, but requires a nested tensor package.
…removed references to np.NaN as that is removed in np 2.0
Some small changes to update things for more recent versions of packages.
…tt/EventStreamGPT into fix_114_typing_with_subject_IDs
@mmcdermott mmcdermott closed this Jun 22, 2024
Copy link

coderabbitai bot commented Jun 22, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

The recent updates across multiple files primarily focus on enhancing the project's functionalities and readability. Key changes include upgrading the Python setup in the workflow to version 3.11, incorporating the loguru logging library for better logging, refining several data handling functionalities, updating various import and method calls for better consistency, and improving documentation. These modifications collectively aim to boost performance, streamline data processes, and enhance logging and error handling throughout the project.

Changes

File/Directory Change Summary
.github/workflows/tests.yml Updated Python version from 3.10 to 3.11.
EventStream/baseline/FT_task_baseline.py Replaced print statements with loguru.logger.info, updated string cache setting, and added Parquet file handling for specific columns.
EventStream/data/README.md Updated representation of missing data values from np.NaN to float('nan').
EventStream/data/config.py Enhanced PytorchDatasetConfig class to support subsampling, added caching and new properties.
EventStream/data/dataset_base.py Refined method signatures, removed abstract methods, enhanced logging, and improved data processing logic.
EventStream/data/time_dependent_functor.py Adjusted pl_expr method and handling of metadata keys in AgeFunctor class.
EventStream/data/types.py Modified list structure by changing null to nul in convert_to_DL_DF method.
EventStream/data/visualize.py Removed age distribution plotting method and attribute, updated group method calls.
EventStream/logger.py Introduced hydra_loguru_init() function for logging initialization in Hydra applications.
EventStream/tasks/profile.py Updated string cache setting and various data type specifications, replaced groupby with group_by.
EventStream/transformer/config.py Enhanced logging by replacing print statements with loguru.logger.warning.
EventStream/transformer/lightning_modules/embedding.py Replaced print statements with loguru.logger.info.
EventStream/transformer/lightning_modules/fine_tuning.py Added loguru logging for various message types.
EventStream/transformer/lightning_modules/generative_modeling.py Incorporated loguru logging and updated configuration logging messages.
EventStream/transformer/lightning_modules/zero_shot_evaluator.py Added loguru logging for errors and info messages.
EventStream/transformer/model_output.py Enhanced exception handling and replaced print statements with loguru.logger.warning.
EventStream/transformer/transformer.py Updated attn_dropout handling and method signatures, enhanced logging and computation logic.
EventStream/utils.py Removed unnecessary sys import, added loguru for error logging in the wrap function.
README.md Clarified polars version dependency and updated function name changes post-version 0.19.
configs/README.md Removed normalizer_config: standard_scaler from YAML configuration.
docs/MIMIC_IV_tutorial/data_extraction_processing.md Updated configuration file paths and commands from EFGPT to ESGPT.
scripts/prepare_pretrain_subsets.py Introduced new changes and enhancements (specific changes not detailed).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants