Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the MAF Benchmark problems #402

Merged
merged 16 commits into from
Aug 28, 2024
Merged

Adding the MAF Benchmark problems #402

merged 16 commits into from
Aug 28, 2024

Conversation

IWNMWE
Copy link
Contributor

@IWNMWE IWNMWE commented Jul 5, 2024

@IWNMWE IWNMWE marked this pull request as draft July 5, 2024 19:23
@zoq
Copy link
Member

zoq commented Jul 7, 2024

Let me know if this is ready for review.

@IWNMWE IWNMWE marked this pull request as ready for review July 22, 2024 18:11
*/

#ifndef ENSMALLEN_PROBLEMS_MAF_THREE_FUNCTION_HPP
#define ENSMALLEN_PROBLEMS_MAF_THREE_FUNCTION_HPP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as in maf4_function.hpp, so this file won't ever actually be read. Maybe can we make sure before we merge this PR that these functions are used in some test somewhere?

Copy link
Contributor Author

@IWNMWE IWNMWE Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will post some results this weekend with MOEAD and AGEMOEA The consistent ones can be turned into tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@IWNMWE
Copy link
Contributor Author

IWNMWE commented Aug 13, 2024

As mentioned before I have added the stable tests only for moea/d due to high time taken by other algorithms (due to non dominated sorting and scoring).

@zoq
Copy link
Member

zoq commented Aug 20, 2024

@mlpack-jenkins test this please

@zoq
Copy link
Member

zoq commented Aug 20, 2024

If this comes back green, this should be ready to go.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@IWNMWE IWNMWE changed the title Added the MAF Benchmark problems Add the MAF Benchmark problems Aug 25, 2024
@IWNMWE IWNMWE changed the title Add the MAF Benchmark problems Adding the MAF Benchmark problems Aug 25, 2024
@zoq zoq merged commit b2eb798 into mlpack:master Aug 28, 2024
3 of 4 checks passed
@zoq
Copy link
Member

zoq commented Aug 28, 2024

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants