-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dagster deployment option using helm chart on local stack #144
Open
ara-25
wants to merge
3
commits into
mlinfra-io:main
Choose a base branch
from
ara-25:dagster-local-deploy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
*.pyc | ||
|
||
# Local .terraform directories | ||
**/.terraform/* | ||
|
||
|
9 changes: 9 additions & 0 deletions
9
src/mlinfra/modules/applications/local/orchestrator/dagster/dagster.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
inputs: | ||
- name: dagster_chart_version | ||
user_facing: true | ||
description: Version of the Dagster Helm chart to use- | ||
default: "1.8.13" | ||
outputs: | ||
- name: dagster_endpoint | ||
description: Dagster access endpoint. | ||
export: true |
22 changes: 22 additions & 0 deletions
22
src/mlinfra/modules/applications/local/orchestrator/dagster/tf_module/main.tf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
locals { | ||
dagster_helmchart_set = [{ | ||
name = "ingress.dagsterWebserver.host" | ||
value = var.dagster_endpoint | ||
type = "auto" | ||
} | ||
] | ||
} | ||
|
||
module "dagster_helmchart" { | ||
source = "../../../../../local/helm_chart" | ||
name = "dagster" | ||
namespace = "dagster" | ||
create_namespace = true | ||
repository = "https://dagster-io.github.io/helm" | ||
chart = "dagster" | ||
chart_version = var.dagster_chart_version | ||
values = templatefile("${path.module}/values.yaml", { | ||
resources = jsonencode(var.resources) | ||
}) | ||
set = local.dagster_helmchart_set | ||
} |
4 changes: 4 additions & 0 deletions
4
src/mlinfra/modules/applications/local/orchestrator/dagster/tf_module/outputs.tf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
output "dagster_endpoint" { | ||
value = var.dagster_endpoint | ||
description = "" | ||
} |
1 change: 1 addition & 0 deletions
1
src/mlinfra/modules/applications/local/orchestrator/dagster/tf_module/values.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
resources: ${resources} |
34 changes: 34 additions & 0 deletions
34
src/mlinfra/modules/applications/local/orchestrator/dagster/tf_module/variables.tf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
variable "dagster_chart_version" { | ||
type = string | ||
description = "Version of the Dagster Helm chart to use" | ||
default = "1.8.13" | ||
} | ||
|
||
variable "resources" { | ||
type = object({ | ||
requests = object({ | ||
cpu = string | ||
memory = string | ||
}) | ||
limits = object({ | ||
cpu = string | ||
memory = string | ||
}) | ||
}) | ||
description = "Resource requests and limits for Dagster pods" | ||
default = { | ||
requests = { | ||
cpu = "100m" | ||
memory = "128Mi" | ||
} | ||
limits = { | ||
cpu = "500m" | ||
memory = "512Mi" | ||
} | ||
} | ||
} | ||
|
||
variable "dagster_endpoint" { | ||
type = string | ||
default = "dagster.localhost" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd also need to pass in
ingress.enabled
astrue
for the ingress to work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, I have used these options to allow a custom hostname to be set for the Webserver (as allowed also in the prefect and milvus deployments).
On second thoughts using
ingress
config to define a custom URL endpoint is going to create an ingress automatically, which the user might not want to do. Would that be fine?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentionally set on all the helm charts deployed on the local deployment environment to allow users to easily access their applications by just using.
<application>.localhost
url in the browser. I have been able to use this for all applications that exist for the local stack and would want dagster to follow suite.