fix: broken-release-for pypa1.11 (#153)

* Updated python publish Signed-off-by: Ali Abbas Jaffri <[email protected]> * Updated release notes Signed-off-by: Ali Abbas Jaffri <[email protected]> --------- Signed-off-by: Ali Abbas Jaffri <[email protected]>
mlinfra-io · Nov 3, 2024 · 0bad6d4 · 0bad6d4
1 parent 72a479b
commit 0bad6d4
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 18 deletions.
diff --git a/.github/workflows/python-publish.yml b/.github/workflows/python-publish.yml
@@ -53,18 +53,18 @@ jobs:
         with:
           pythonVersion: "3.11"
           dependencyType: "docs"
-      - name: Append release notes to RELEASE_NOTES.md # automatically update release notes on new release
-        run: |
-          git config --local user.email "[email protected]"
-          git config --local user.name "GitHub Actions"
-          git checkout main
-          echo "Appending new release notes to RELEASE_NOTES.md"
-          echo -e "\n## $(echo "${{ github.event.release.published_at }}" | cut -d'T' -f1) - version ${{ github.event.release.tag_name }}\n" >> RELEASE_NOTES.md
-          echo "${{ github.event.release.body }}" >> RELEASE_NOTES.md
-          echo -e "\n---\n" >> RELEASE_NOTES.md
-          git add RELEASE_NOTES.md
-          git commit -m "Updated release notes for ${{ github.event.release.tag_name }}"
-          git push origin main
+      # - name: Append release notes to RELEASE_NOTES.md # automatically update release notes on new release
+      #   run: |
+      #     git config --local user.email "[email protected]"
+      #     git config --local user.name "GitHub Actions"
+      #     git checkout main
+      #     echo "Appending new release notes to RELEASE_NOTES.md"
+      #     echo -e "\n## $(echo "${{ github.event.release.published_at }}" | cut -d'T' -f1) - version ${{ github.event.release.tag_name }}\n" >> RELEASE_NOTES.md
+      #     echo "${{ github.event.release.body }}" >> RELEASE_NOTES.md
+      #     echo -e "\n---\n" >> RELEASE_NOTES.md
+      #     git add RELEASE_NOTES.md
+      #     git commit -m "Updated release notes for ${{ github.event.release.tag_name }}"
+      #     git push origin main
       - name: Publish documentation
         uses: ./.github/actions/mike-docs
         with:
@@ -88,8 +88,12 @@ jobs:
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
           skip-existing: true # tolerate release package file duplicates
+          attestations: false
           repository-url: https://test.pypi.org/legacy/
       - name: Publish distribution 📦 to PyPI
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
+          verbose: true
+          print-hash: true
+          # Temp workaround since attestations are on by default as of gh-action-pypi-publish v1.11.0
           attestations: false
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -13,12 +13,11 @@
 
 ## 2024-11-02 - version 0.0.20
 
-### What's Changed
-* fix: Set attestation as false in pypi release by @aliabbasjaffri in https://github.com/mlinfra-io/mlinfra/pull/152
-* [Snyk] Security upgrade zipp from 3.15.0 to 3.19.1 by @aliabbasjaffri in https://github.com/mlinfra-io/mlinfra/pull/151
-
-
+### What's Changed
+* fix: Set attestation as false in pypi release by @aliabbasjaffri in https://github.com/mlinfra-io/mlinfra/pull/152
+* [Snyk] Security upgrade zipp from 3.15.0 to 3.19.1 by @aliabbasjaffri in https://github.com/mlinfra-io/mlinfra/pull/151
+
+
 **Full Changelog**: https://github.com/mlinfra-io/mlinfra/compare/0.0.19...0.0.20
 
 ---
-