Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIBSEARCH-919] Add a class to Author browse links for GA tracking #100

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[LIBSEARCH-919] Add a class to Author browse links for GA tracking #100

merged 1 commit into from
Oct 10, 2023

Conversation

erinesullivan
Copy link
Collaborator

Overview

There is currently no direct way for GTM to track cross reference links while browsing by author. The cross-reference-link class has been added.

This pull request resolves LIBSEARCH-919.

Testing

  • Run the tests to make sure they pass (docker-compose run --rm web bundle exec rspec).
  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Run the site and see if the class shows in the source code.

@erinesullivan erinesullivan added the enhancement New feature or request label Oct 10, 2023
@erinesullivan erinesullivan self-assigned this Oct 10, 2023
@erinesullivan erinesullivan merged commit e86d886 into main Oct 10, 2023
1 check passed
@erinesullivan erinesullivan deleted the LIBSEARCH-919-add-a-class-to-author-browse-links-for-ga-tracking branch October 10, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erinesullivan erinesullivan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erinesullivan