ECR Image Fix (#124)

* Fixed issue with not being able to allowlist ECR Images * Fixed issue with ECR Image cleanup never being run * Changelog * Removed images from run statement * CRLF to LF
mlevit · Jul 16, 2022 · 60d1a56 · 60d1a56
1 parent 8dacdc0
commit 60d1a56
Show file tree

Hide file tree

Showing 3 changed files with 485 additions and 474 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # AWS Auto Cleanup Changelog
 
+- UNRELEASED
+
+- Fixed issue with not being able to allowlist ECR Images.
+- Fixed issue with ECR Image cleanup never being run.
+
 ## 2.2.0
 
 - Added wildcard support to allowlist resource ID. Comparisons are now performed using the [fnmatch](https://docs.python.org/3/library/fnmatch.html) Python module. The following special characters can be used:

diff --git a/api/src/allowlist/create.py b/api/src/allowlist/create.py
@@ -47,7 +47,7 @@ def lambda_handler(event, context):
         return get_return(400, "Could not read Auto Cleanup settings", parameters, None)
 
     try:
-        service, resource, resource_id = parameters.get("resource_id").split(":")
+        service, resource, resource_id = parameters.get("resource_id").split(":", 2)
     except Exception as error:
         print(f"[ERROR] {error}")
         return get_return(