Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build and support Documenter v1 #168

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Fix docs build and support Documenter v1 #168

merged 6 commits into from
Dec 1, 2023

Conversation

sethaxen
Copy link
Member

@sethaxen sethaxen commented Dec 1, 2023

Some of the example blocks were failing to execute due to namespace clashes, which are now fixed. Also, we now use Documenter v1.

This also required adding flattened_varnames_list to the API, which is inelegant but for now okay.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60e9ada) 89.66% compared to head (cc549d5) 89.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files          13       13           
  Lines         590      590           
=======================================
  Hits          529      529           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethaxen sethaxen merged commit 22a6100 into main Dec 1, 2023
11 of 13 checks passed
@sethaxen sethaxen deleted the documenterv1 branch December 1, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant