Update WoodburyPDMat to match PDMats changes #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now necessary because of JuliaStats/PDMats.jl#179
Now necessary because of JuliaStats/PDMats.jl#183
|
Failures on docs examples and integration tests are unrelated to this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 93.00% 89.66% -3.35%
==========================================
Files 13 13
Lines 572 590 +18
==========================================
- Hits 532 529 -3
- Misses 40 61 +21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PDMats PRs broke our implementation of the PDMats API for
WoodburyPDMat:convertdefinitions JuliaStats/PDMats.jl#179(un)whitenand(inv)quadwith static arrays JuliaStats/PDMats.jl#183This PR updates the code to fix these issues. Personally, I think this PRs to PDMats were needed, I also think they were breaking and should have been marked as such.