MicroServing Implementation #3064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinhongyii
commented
Dec 13, 2024
| engine_config, // | ||
| model_configs, // | ||
| trace_recorder), | ||
| // EngineAction::BatchJumpForward(models, tokenizer, trace_recorder), |
There was a problem hiding this comment.
I'm not sure whether we can delete batch jumpforward here.
| @@ -51,7 +51,8 @@ def extract_creation_args(func: relax.Function) -> Dict[str, Any]: | |||
| "rope_scaling": json.loads(args[10].value), | |||
| "rope_ext_factors": args[11], | |||
| "rotary_dim": args[12].value.value, | |||
| "dtype": args[13].value, | |||
| "enable_disaggregation": bool(args[13].value.value), | |||
There was a problem hiding this comment.
Is it safe to remove enable_disaggregation? The argument is not propagated after this pass
There was a problem hiding this comment.
No, this one is necessary. It's part of kwargs and will be passed along
mlc-llm/python/mlc_llm/compiler_pass/dispatch_kv_cache_creation.py
Lines 103 to 108 in fffb785
python/mlc_llm/interface/router.py
Outdated
| return error_protocol.create_error_response( | ||
| HTTPStatus.BAD_REQUEST, message="The request has disconnected" | ||
| ) | ||
| # TODO(Charlie): This is copied from engine.py -- why is it here? Non-streaming only has a single chunk right? |
There was a problem hiding this comment.
this question is not answered.
|
cc: @MasterJH5574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces MicroServing API. MicroServing introduces simple yet effective REST APIs to support fine-grained sub-request level actions. A programmable router transforms user requests into sub-request calls, lifting fine-grained scheduling to the API level, thus enabling the dynamic reconfiguration of different orchestration patterns.
Co-authored-by: Ruihang Lai [email protected]
Co-authored-by: Charlie Ruan [email protected]
Co-authored-by: Yingcheng Wang [email protected]