Vasil update #73
Merged
Vasil update #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix local cluster & Add PlutusV2 cost model.
- updated: cluster-data files, form current wallet commit - updated: BPI rev - fixed: breaking API changes - partially-fixed: tests
Vasil compliance update
This was referenced Aug 18, 2022
- wait longer before collecting final Values from wallets - node waiting ensures some slots are produced before proceed
mikekeke
force-pushed
the
gergely/vasil
branch
from
541fabc to
ecefab7
Compare
|
Plutip updated according to related BPI PR. |
mikekeke
requested review from
mikekeke,
IAmPara0x,
Anteproperispomenon,
MitchyCola and
zmrocze
mikekeke
force-pushed
the
gergely/vasil
branch
from
8f8731f to
c3d4693
Compare
bladyjoker
approved these changes
Aug 26, 2022
MitchyCola
reviewed
Aug 26, 2022
Vasil waiting for index
The previous branch got messed up after some merge issues. So I created a new branch based on the latest working commit of `gergely/vasil` and just copied over `AdjustTx.hs` and made the required changes to `plutip.cabal` and `Integration.hs`. The test works now.
mikekeke
force-pushed
the
gergely/vasil
branch
from
0049cee to
ae394a6
Compare
ngua
reviewed
Aug 30, 2022
| let noOfSlots = 10 | ||
| slotLen = 1000 | ||
| timeDiff = POSIXTime (noOfSlots * slotLen) | ||
| let timeDiff = POSIXTime 5_000 |
There was a problem hiding this comment.
It might be a good idea to document these numeric values or even make them into constants. It will be helpful to know what they signify if they need to updated again in the future
There was a problem hiding this comment.
I think the way it was written previously was better in this regard (nOfSlots * slotLen is easier to understand)
There was a problem hiding this comment.
Note: if we decide to go back to nOfSlots * slotLen representation, we will need to get real slot length from cluster, as it can vary (although it's not too clear yet how to set it after update to newer version of cardano-wallet framework; default is 0.2 sec).
Removed unused imports, and made sure all imports were either qualified or had explicit import lists. Also replaced some deprecated functions and added a proper signature for `runAdjustTest`.
MitchyCola
reviewed
Aug 30, 2022
MitchyCola
reviewed
Aug 30, 2022
- switch to final BPI Vasil compliant version - address PR review comments - adjust tests
Add Test that `adjustUnbalancedTx` works (updated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update BPI (and plutus-apps) accord to this PR mlabs-haskell/bot-plutus-interface#103
We also need the updated wallet for the cluster: cardano-foundation/cardano-wallet#3318