Plutip server fixes #154
Merged
Plutip server fixes #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses node query and waits till node queries for all wallets return any utxos at the cluster startup in plutip-server.
This was referenced Nov 27, 2022
Closed
|
This is meant to be used in ctl. Pr with these changes targeting master is at #155 |
klntsky
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startClusterhandler doesn't guarantee that wallets are funded. Waiting properly for the funds takes strangely long time. Im leaving fixing this out of this pr, but this is no worse than before when we waited for 2 seconds.I reproduced the cluster startup failure using forked cluster which always chose unavailable ports. This hits " resource busy (Address already in use)" when cardano-node picks used up port due to a race condition. Retrying aims to make this case very rare.