Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time of check to time of use bug in plutip-server. #153

Open
zmrocze opened this issue Nov 22, 2022 · 0 comments
Open

Time of check to time of use bug in plutip-server. #153

zmrocze opened this issue Nov 22, 2022 · 0 comments

Comments

@zmrocze
Copy link
Contributor

zmrocze commented Nov 22, 2022

In the handler we check if MVar is empty and then act based on the result. See here and there. There is a race if i.e. two handlers try to stop cluster, and witness it running. Then the second thread would deadlock on the just emptied MVar.

The assumption initially was that you're not gonna spam server with stop requests - but that's exactly what we do now in ctl to check if server is ready.

This was referenced Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant