Cluster fixes #155
Closed
Cluster fixes #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses node query and waits till node queries for all wallets return any utxos at the cluster startup in plutip-server.
Merged
mikekeke
reviewed
Nov 28, 2022
| let tracer' = trMessageText trCluster | ||
| waitForRelayNode tracer' rn | ||
| maybePort <- handleChainIndexLaunch (chainIndexMode conf) rn dir | ||
| let cEnv = | ||
| mChainStarted <- handleChainIndexLaunch (chainIndexMode conf) rn dir |
There was a problem hiding this comment.
An IMHO, but this stuff starting to get a bit involved. I think because of the way handleChainIndexLaunch is done.
Maybe do something like
getChIndexPort :: ChainIndexMode -> Maybe ChainIndexPortand then clearly branch on it like
mPort = getChIndexPort (chainIndexMode conf)
case mPort of
Just port -> bracket (startIndex port rn dir) stopIndex (<make cEnv and run setup and actions>)
-- or
-- Just port -> withChainIndex port rn dir (<make cEnv and run setup and actions>)
Nothing -> (<make cEnv and run setup and actions>)or something like that, and trash handleChainIndexLaunch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analog of #154 targeting master.
Waiting for cluster funds is already present at master (in different form) so that wasn't changed.