fix job import of project with whitespace #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debugging. fix job import with a name containing whitespace
|
Good job! How did you test that? |
|
I have tested it during a migration of jobs that contains space at my office. Adding a test is not simple because for the moment, the function ImportJob has no test. I think that the commit is small enough to be checked without adding a test. |
|
I think it's a quite cool contribution, thank you! @mlabouardy would you like to merge this? |
|
how can i import to jenkins which is working with my Gsuiute SSO ? it always says Unauthorized 401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix job import with a name containing whitespace by properly encode the url
display the HTTP error code in case of the import failed to help debugging