-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bodyPix optimization #63
Conversation
What do you think about calling this
Parallel language with Also, I could imagine a future where we have non-body segmentation models as part of ml5.js. We could consider staying very generic with Looking over these:
I think I lean towards |
I think |
I think this PR is ready for review :) I have updated the documentation and renamed the model bodySegmentation. I have also further improved the performance of p5 image generation. |
It seems like calling the mask() function repeatedly in draw() causes canvas2D to throw a warning. Through it might a an issue on p5's end. I have created an issue in the p5 repo: processing/p5.js#6592. |
I have updated the I have also switched the behavior of "person" and "background" around. Now, when the segmentation mask is applied on a video through p5's mask() function, the effects are the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run all of the examples and they look great! I'm going to go ahead and merge this branch. We can make adjustments and/or add new examples later. @MOQN you may especially be excited to test this!
@ziyuan-linn what do you think about doing another temporary release and adding these examples to the web editor collection + preliminary documentation?
cc @sproutleaf to keep the website team in the loop!
@shiffman Thank you for reviewing this PR. I am happy to do another temporary release! Some quick questions on top of my mind: Do you think it is worth it to have a basic changelog/release notes for the alpha releases? The current version is cc: @sproutleaf |
This PR updates BodyPix's API and optimizes its performance.
detectStart()
,detectStop()
, anddetect()
interface, similar to handpose and bodyposeml5.bodyPix(modelName, options, callback)
. The stringmodelName
specifies the underlying model to usemaskType
property in theoptions
object as"person"
,"background"
, or"parts"
TODO:
Please let me know if I'm missing anything :)