-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BodyPose cleanup #178
BodyPose cleanup #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you @ziyuan-linn! Looks like you tagged @alanvww for a review, I'm happy to merge afterwards!
Awesome work! Thanks for letting me know about the update, I will work on the doc ASAP. @shiffman We are ready to merge! |
Thoughts: It might make sense to move functions like mirrorBoundingBox to a utility file, if we want to use that logic in multiple models. There are some types that can be more specific, but it’s annoying if we have to write out the union of possible image types every time. The return types could also be more specific (an array of what?). We can define a type for the prediction object and instead of Promise it can be Promise<Array>. That might not be worth the effort, unless… It would be really great if we can figure out a way to sync property descriptions between the code comments and the documentation. |
Thank you for the feedback @lindapaiste, feel free to open any issues with proposals for these changes if you like! |
This PR updates the comments and refactors the code of BodyPose. No change to the user API.
handleOptions
next to the options object comments.BodyPose
class.This PR also removes the
window._incrementPreload
andwindow._decrementPreload
calls to address the bug in #175.