Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Prometheus metric export #134
base: master
Are you sure you want to change the base?
[Feat] Prometheus metric export #134
Changes from 11 commits
9bf5ce9
dd881e8
d21cfd1
4681796
e8bfe7b
1b9e541
26e925e
3569b68
29e615b
2ae388f
6a9daa5
69c42da
4704a67
5666ba5
863f257
35ab267
4aa0f39
1e996a4
8e1d35b
7e47fbb
52f2fa7
30b807e
c53c72e
ffa46d1
5f67d5c
b96b32e
9aa1888
b62ed5d
0dbb236
753f1de
77ff075
793a186
30b7e1c
3ab4d89
f032488
73d8c8c
c153ef2
0aa03d4
0e0e63c
9228b74
866365e
53f6c62
c014ff1
f7e5d79
f8d5b67
8c5456e
4c2e794
d8a6f1c
d85f255
5f9cc6b
0f8d550
49acc9a
f18ecb9
2276ac2
dea8b5d
9411495
ef48d88
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the random image-related stuff that were added and completely remove the power limit optimizer, not commenting it out. Overall, this file needs cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines are very long. They're better off using multiple lines, like before the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this
begin_window
,train
, thenend_window
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments are useful. Please bring them back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline.