Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor abstract base class for structural ensembles #291

Closed
mjo22 opened this issue Dec 10, 2024 · 1 comment
Closed

Refactor abstract base class for structural ensembles #291

mjo22 opened this issue Dec 10, 2024 · 1 comment
Labels
refactor

Comments

@mjo22
Copy link
Owner

mjo22 commented Dec 10, 2024

The AbstractStructuralEnsemble has an abstract attribute called conformational_space. This is not particularly descriptive across concrete instances of this class, so best to just remove it.
@mjo22 mjo22 added the refactor label Dec 10, 2024
@mjo22
Copy link
Owner Author

mjo22 commented Dec 10, 2024

Closed with #293

@mjo22 mjo22 closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjo22