Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when hiding waveforms in Deere #14170

Merged
merged 6 commits into from
Jan 14, 2025
+87 −55
Merged

Fix crash when hiding waveforms in Deere #14170

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6fc3426
Add missing p prefix to pTexture
daschuer Jan 12, 2025
ac9ac48
Make MarkerGeometry a class with const getter
daschuer Jan 14, 2025
5f693d0
Don't use runtime asserts
daschuer Jan 14, 2025
5f82622
Return early if there is nothing to paint.
daschuer Jan 14, 2025
8ae7d2f
Improve variable names
daschuer Jan 14, 2025
4c368f4
Use VERIFY_OR_DEBUG_ASSERT() to check for valid images
daschuer Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/waveform/renderers/waveformmark.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ class MarkerGeometry {
};

QImage WaveformMark::generateImage(float devicePixelRatio) {
assert(needsImageUpdate());
DEBUG_ASSERT(needsImageUpdate());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERIFY_OR_DEBUG_ASSERT ?
IIUC all below would be a no-op otherwise, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but we assert that it never happens and when it happens, it does no harm.


// Load the pixmap from file.
// If that succeeds loading the text and stroke is skipped.
Expand Down