Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux desktop file #14153

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Update Linux desktop file #14153

merged 2 commits into from
Jan 10, 2025

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jan 9, 2025

Add Keywords and more translations.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@JoergAtGithub
Copy link
Member

Spellcheck errors in translated strings are expected. LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit a807be6 into mixxxdj:2.5 Jan 10, 2025
12 of 13 checks passed
@Holzhaus
Copy link
Member

Please do not merge PRs with failing pre-commit. We should add an exception in the pre-commit config if the spellcheck errors are expected. Now all PRs are failing CI.

Holzhaus added a commit to Holzhaus/mixxx that referenced this pull request Jan 13, 2025
The codespell hook is failing due to translations. This was introduced
in PR mixxxdj#14153. This commits excludes the file from the codespell check.
@Holzhaus
Copy link
Member

Fix in #14169.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants