Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ansible extra #948

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KamilaBorowska
Copy link

Fixes #947.

Thanks for creating a PR! Here's a quick checklist to pay attention to:

  • Please add an entry to docs/changelog.rst as appropriate.

  • Has some new parameter been added or semantics modified somehow? Please
    ensure relevant documentation is updated in docs/ansible.rst and
    docs/api.rst.

  • If it's for new functionality, is there at least a basic test in either
    tests/ or tests/ansible/ covering it?

  • If it's for a new connection method, please try to stub out the
    implementation as in tests/data/stubs/, so that construction can be tested
    without having a working configuration.

@KamilaBorowska
Copy link
Author

Right, that won't work because for 2.10 the package is called ansible-base, not ansible-core.

@KamilaBorowska
Copy link
Author

Eh, I guess I will call it ansible-core extra instead, and accept it won't match ansible-base. For my use-case of preventing ansible updates before mitogen gets updated it's acceptable.

@moreati
Copy link
Member

moreati commented Aug 25, 2022

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KamilaBorowska KamilaBorowska force-pushed the ansible-extras branch 2 times, most recently from c4ad0ef to 400ae5a Compare November 8, 2022 08:41
@KamilaBorowska KamilaBorowska force-pushed the ansible-extras branch 4 times, most recently from fbaf53c to 34a72b6 Compare February 6, 2023 08:37
@KamilaBorowska
Copy link
Author

Updated the changelog to put this change in "Unreleased" section.

@moreati
Copy link
Member

moreati commented Apr 12, 2024

If you're till interested, there may be a way this could be work across ansible-base & ansible-core.

  1. Release distributions of a new project (e.g. superluminiferous-aether) on PyPI with <major.minor> versions that correspond to ansible-base/ansible-core version and that require that corresponding ansible-base/ansible-core <major.minor>
  2. Have mitogen[ansible] require superluminiferous-aether >= 2.10, <= 2.16.

I'm not sure yet, if the benefit outweighs the complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ansible as an extras feature on PyPI
2 participants