Python312 upgrade #357
Merged
Python312 upgrade #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
==========================================
- Coverage 61.40% 52.94% -8.46%
==========================================
Files 16 16
Lines 1705 1713 +8
Branches 115 307 +192
==========================================
- Hits 1047 907 -140
- Misses 642 793 +151
+ Partials 16 13 -3
|
Anas12091101
force-pushed
the
python312-upgrade
branch
2 times, most recently
from
becc0fc to
fd8c571
Compare
Anas12091101
force-pushed
the
python312-upgrade
branch
from
d587fb2 to
2f94958
Compare
Anas12091101
force-pushed
the
python312-upgrade
branch
2 times, most recently
from
673b028 to
435fe3b
Compare
Anas12091101
force-pushed
the
python312-upgrade
branch
from
435fe3b to
e4fc0fd
Compare
Anas12091101
force-pushed
the
python312-upgrade
branch
from
294ff61 to
7d86f4c
Compare
Anas12091101
force-pushed
the
python312-upgrade
branch
from
7d86f4c to
99ba2b5
Compare
There was a problem hiding this comment.
The code itself looks good & the functionality is also intact. I think we can now also remove the deprecation warning like below. I was able to import the correct files in LMS & CMS shells.
edx.devstack.lms | 2024-03-22 10:28:53,486 WARNING 1219 [py.warnings] [user 3] [ip 192.168.65.1] warnings.py:109 - /edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/edx_sga/sga.py:37: DeprecatedPackageWarning: Please use import xblock.utils.studio_editable instead of xblockutils.studio_editable because the 'xblock-utils' package has been deprecated and migrated to within 'xblock' package.
edx.devstack.lms | from xblockutils.studio_editable import StudioEditableXBlockMixin
|
Tests will continue to fail until the merge of openedx/edx-platform#34398. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
#356
What's this PR do?
Upgrade Python to version 3.12 and remove all depreciation warnings
How should this be manually tested?
Note
The xblock-sdk workbench currently doesn't work with XBlock==2.0.0. Hopefully the issue shall be solved in the new release of xblock-sdk. Therefore, the version of xblock has been temporarily set to 1.10.0 in the test_requirements.txtFixed